Write CRT data asynchronously #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is also blocking on the protocol test skips that are in #318 |
JordonPhillips
changed the base branch from
develop
to
suppress-new-protocol-tests
JordonPhillips
force-pushed
the
http-stream-support
branch
from
99323d2 to
a0f8991
Compare
This updates the CRT bindings to write data to its ByteIO body asynchronously rather than buffering it all into memory when making a call. This should enable us to support event streaming, and also prevent us from buffering a huge amount of data into memory, even for synchronous bodies of uncertain size.
JordonPhillips
force-pushed
the
http-stream-support
branch
from
a0f8991 to
b210f52
Compare
nateprewitt
reviewed
Oct 18, 2024
Comment on lines
+335
to
+336
| # Should we call close here? Or will that make the crt unable to read the last | ||
| # chunk? |
Contributor
There was a problem hiding this comment.
Have we tested this at all? My initial impression is we'd throw a ValueError in the CRT trying to read from a closed object. I would think this gets cleaned up for us automatically once it goes out of scope?
Contributor
Author
There was a problem hiding this comment.
The problem is that it's hard to test the CRT without a live connection. If nothing else, the BytesIO will eventually get garbage collected since when this task complete there'll be no more references to it.
Contributor
There was a problem hiding this comment.
Maybe add a mark this with a TODO so we know to come back eventually? Otherwise, that seems fine.
Fix comment typos Co-authored-by: Nate Prewitt <[email protected]>
nateprewitt
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the CRT bindings to write data to its ByteIO body asynchronously rather than buffering it all into memory when making a call. This should enable us to support event streaming, and also prevent us from buffering a huge amount of data into memory, even for synchronous bodies of uncertain size.
This should also allow us to get rid of those consume_body utility functions that I detest. But one thing at a time.
Also, we really need to work on standing up a local http2 server for testing. Integ tests will be nice too and all but I'm nevertheless nervous about how hard this is to test.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.